-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Expand test coverage for native AOT on android #121217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Expand native AOT smoke tests to all libraries tests - Add job for runtime smoke tests using native AOT on emulator
Move NDK compiler logic to a shared props file and import it in test and build projects to unify Android NativeAOT and Mono builds.
- Set ASSETS_DIR for crypto tests (using same pattern as existing crypto test) - Set AppContext.BaseDirectory We should probably change crypto tests to use just AppContext.BaseDirectory.
- Use ReferenceXUnitWrapperGenerator != false to define SINGLE_FILE_TEST_RUNNER (android & singlefile targets) instead of IsFunctionalTest - Condition SingleFileTestRunner compile and TrimmerRootAssembly (TestUtilities) on wrapper/generator and SkipTestUtilitiesReference - Add Android NativeAOT publish/trim settings and set NativeLib/CustomNativeMain for android nativeaot - Make DisableImplicitFrameworkReferences respect preexisting value and add explicit DisableImplicitFrameworkReferences=false in nativeaot tests dir - Import testing\tests.targets when TargetsAndroid is true - Update many NativeAOT smoke tests Main signatures to public static int Main(string[] args) to match runner invocation
- Ensure they have Main entry point - Tighten MSBuild conditions: - Only set NativeLib/CustomNativeMain for Android when OutputType == Exe - Only import testing/tests.targets for Android when using MicrosoftNETSdk and building executables - Make TestNativeAOT/UseNativeAOTRuntime defaults apply when TestBuildMode == nativeaot and only include monodroid-nativeaot.cs for executable/XUnit-wrapper cases
This reverts commit 4ed06ec.
- Avoid importing logic for SharedLibrary - Fix library filename - Set HasMergedInTests to ensure projects build
This reverts commit 37b7b4e.
This import is now covered by the IsMergedTestRunnerAssembly property. Fixes a warning about a double import. Fixes issue where mono runtime tests are getting incorrect assembly name due to this undesired import.
|
/azp run runtime-androidemulator |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I don't know anything about xharness or android testing. Would be nice if someone else who knows about those could look at it from that angle.
| return path + Path.DirectorySeparatorChar; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave this in?
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Fix left-over whitespace change - Remove unnecessary ClrTestTargetUnsupported condition
|
/azp run runtime-android |
|
/azp run runtime-androidemulator |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@simonrozsival @jtschuster you've both touched the android test infrastructure, I'd appreciate another review from one of you if you get a chance! |
jtschuster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
/azp run runtime-androidemulator |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #120715